Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set default options for dev command #4932

Merged
merged 1 commit into from
May 16, 2022
Merged

set default options for dev command #4932

merged 1 commit into from
May 16, 2022

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented May 15, 2022

Set default options for the dev command, similar to the preview command.

This shouldn't break anything, but could be helpful:

  1. Ensure port is 3000, as Vite 3 changes to 5173.
  2. Set --host to localhost as Vite defaults to 127.0.0.1 in dev.

Re no2, while Vite still forces 127.0.0.1 when localhost is specified (ref vitejs/vite#7075), this will be changed in Vite 3 and the behaviour should be consistent with preview then.

Also ref: #4729

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented May 15, 2022

🦋 Changeset detected

Latest commit: d453dfe

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@bluwy bluwy merged commit 6205a11 into master May 16, 2022
@bluwy bluwy deleted the dev-command-options branch May 16, 2022 06:59
@bluwy bluwy mentioned this pull request May 16, 2022
5 tasks
bluwy added a commit that referenced this pull request May 16, 2022
Rich-Harris pushed a commit that referenced this pull request May 16, 2022
* fix dev --host option behaviour

* revert #4932

* set default port to 3000

* update changeset

* one more spot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants